[libcxx-commits] [PATCH] D119057: [libc++][ranges] Implement rbegin, rend, crbegin and crend.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D119057#3308015 <https://reviews.llvm.org/D119057#3308015>, @Quuxplusone wrote:

> @ldionne LGTY? Thoughts on cherry-picking into release/14.x so we can say we've got all of [range.access] in 14.x?

This would be disabled due to it being incomplete anyway, so I don't see the point in cherry-picking it back to 14.x.



================
Comment at: libcxx/include/__ranges/access.h:284
+  [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const
+    noexcept(noexcept(end(__t)))
+  {
----------------
var-const wrote:
> Quuxplusone wrote:
> > Attn @ldionne — it's our new policy to start using unadorned `std::` in new code, is that right? Or should we keep the `_VSTD::` convention in case the release/14.x process discovers an unexpected problem and we need to roll back the `#define _VSTD std` change?
> > (Using `std::` here is totally fine if it's our policy; I just want to hear a clear "yes" from @ldionne.)
> (Yeah, I did that due to the recent patch/direction to remove `_VSTD`. Happy to use `_VSTD` if necessary)
Yes, we can use `std::`, but thanks for checking.


================
Comment at: libcxx/include/__ranges/rbegin.h:28
+
+#if !defined(_LIBCPP_HAS_NO_CONCEPTS)
+
----------------
This should be guarded by `HAS_NO_INCOMPLETE_RANGES` too (and other headers too).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119057/new/

https://reviews.llvm.org/D119057