[libcxx-commits] [PATCH] D119134: [libcxx] Silence -Wformat-nonliteral warnings in the Windows support code

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/src/support/win32/locale_win32.cpp:100
     __libcpp_locale_guard __current(loc);
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wformat-nonliteral"
----------------
mstorsjo wrote:
> Mordante wrote:
> > I just noticed D119295 so maybe use the macros added there before landing. (Assuming that patch will be accepted.)
> Yes, maybe - I was hoping to backport this to 14.x to silence the build there too, so then it'd depend on whether that one (which is a bit bigger) is deemed OK to backport.
I can also hold back on D119295 until this PR is shipped. Just notify me on discord when you have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119134/new/

https://reviews.llvm.org/D119134