[libcxx-commits] [PATCH] D119134: [libcxx] Silence -Wformat-nonliteral warnings in the Windows support code

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D119134#3308361 <https://reviews.llvm.org/D119134#3308361>, @ldionne wrote:

> Would it make sense to turn these warnings into errors when building the library? That way we can never regress.

For building in CI configurations, I think it would make sense to tighten down as many configurations as possible with `-Werror`, to avoid regressing something that has been clean at some point. For non-CI builds, I don't think we should be building with `-Werror` by default though.

(The clang-cl builds are incredibly noisy these days, though, due to `[[no_unique_address]]` not being recognized in MSVC mode - I haven't had time to bring that issue up, and I'm not sure if we want to wrap the attribute in a macro or not.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119134/new/

https://reviews.llvm.org/D119134