[libcxx-commits] [PATCH] D119173: [libc++] Remove _LIBCPP_ABI_UNSTABLE

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D119173#3307920 <https://reviews.llvm.org/D119173#3307920>, @paulkirth wrote:

> In D119173#3307636 <https://reviews.llvm.org/D119173#3307636>, @ldionne wrote:
>
>> In D119173#3306641 <https://reviews.llvm.org/D119173#3306641>, @paulkirth wrote:
>>
>>> Hi,
>>>
>>> We're seeing breakage in Fuchsia's Clang canary builders for Linux (aarch64 & X86_64) that seem related to this patch, (though it may be related to D119036 <https://reviews.llvm.org/D119036> ? I can't tell).
>>>
>>> Sorry for the late notification. This was hidden by a breakage in an different LLVM component, so we missed this for a bit.
>>> [...]
>>
>> Thanks for the heads up. It was indeed caused by D119036 <https://reviews.llvm.org/D119036>, and should be fixed by eceb40183cbb9442c7f42e7a4b8324abb50c32ab <https://reviews.llvm.org/rGeceb40183cbb9442c7f42e7a4b8324abb50c32ab>.
>>
>> Can you folks move the Fuchsia bots to our pre-commit CI infrastructure?
>
> @ldionne let me loop @phosek in, since he will be better able to answer you about that.

We cannot move existing bots over since we would loose integration into the rest of Fuchsia's CI infrastructure which lets us test every toolchain against the rest of the platform. We have been thinking about setting up additional upstream builders for libc++ though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119173/new/

https://reviews.llvm.org/D119173