[libcxx-commits] [PATCH] D119335: [libc++][NFC] Reformat and modernize compressed_pair.h

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

Nice cleaups! LGTM modulo some style nits and the C++03 breakage..



================
Comment at: libcxx/include/__memory/compressed_pair.h:33
+  using reference = _Tp&;
+  using const_reference = const _Tp& ;
 
----------------
Same on line 31.
Just curious did you reformat manually or using clang-format?


================
Comment at: libcxx/include/__memory/compressed_pair.h:38
+
+  template <class _Up, class = __enable_if_t<!is_same<__compressed_pair_elem, typename decay<_Up>::type>::value>>
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR explicit
----------------
Needed for C++03.


================
Comment at: libcxx/include/__memory/compressed_pair.h:61
+  using const_reference = const _Tp&;
+  using __value_type = _Tp ;
+
----------------



================
Comment at: libcxx/include/__memory/compressed_pair.h:67
+
+  template <class _Up, class = __enable_if_t<!is_same<__compressed_pair_elem, typename decay<_Up>::type>::value>>
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR explicit
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119335/new/

https://reviews.llvm.org/D119335