[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D116689#3306286 <https://reviews.llvm.org/D116689#3306286>, @phosek wrote:

> This change skips the extraction and repackaging step altogether and instead packages all objects that should go into the final library directly (through CMake dependencies). I think that approach is also more efficient (no extraction and repackaging) and explicit (CMake and Ninja know exactly which files form the final archive) at slight increase in CMake code complexity which IMO is a good tradeoff.

I also want to point out that I tried to minimize the number of changes in this patch, but I plan to do additional cleanup as a follow up which should simplify the build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689