[libcxx-commits] [PATCH] D117966: [libcxx][test] tests for strengthened `noexcept` are non-portable

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

IIRC the idea was to make functions `noexcept` as much as we could because that's conforming and we thought that we'd never actually want to do anything else but terminate if an exception was thrown from those. But revisiting this, I agree it's a weird choice to have made and I would support removing the non-required `noexcept`s (in particular the conditional ones that add complexity). @Quuxplusone if you want to make a pass at those, be my guest, I'll be happy to review.

In the meantime, this looks OK to me since that behavior is indeed libc++ specific. I think the CI failure is OK to ignore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117966/new/

https://reviews.llvm.org/D117966