[libcxx-commits] [PATCH] D119198: [libc++] Remove default_searcher from experimental/functional

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/include/experimental/functional:116
 
+#if _LIBCPP_STD_VER > 11
 template<class _Key, class _Value, class _Hash, class _BinaryPredicate, bool /*useArray*/> class _BMSkipTable;
----------------
Quuxplusone wrote:
> Orthogonally: What's the deal with `std::experimental::boyer_moore_searcher`? Have we implemented `std::boyer_moore_searcher` https://en.cppreference.com/w/cpp/utility/functional/boyer_moore_searcher yet? (No. We haven't.)
> 
> Ordering-wise, it would sure have made a lot more sense for us to have implemented `std::boyer_moore_{,horspool_}searcher` all at once, and then we could yank `std::experimental::*_searcher` all at once. The current state — where you //need// `std::experimental::` for two of the searchers, but (@jloser proposes) you'll //need// `std::` for the other one — seems really unfortunate to me. But the time for us to fix that was 2 releases ago; it's not @jloser's fault that we didn't do it, and so //maybe// it shouldn't stop us from removing deprecated features according to schedule.
Agree re the ordering. We //could// take `std::experimental::boyer_moore_{,horspool_}searcher` and figure out the loose ends to put them into `std` and then remove all the searchers from `experimental/functional` at once. If we do that, then I'll close this PR, and I //might// volunteer to implement the searchers into `std` to complete the work effectively. The alternative is to piecemeal the removals by doing just `default_searcher` and `make_default_searcher` since `std::default_searcher` already is implemented today, which is what this PR is.

@ldionne thoughts on piecemeal removal vs all-at-once? I don't think I'd get to the other searchers for a little while if we want to do the all-at-once approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119198/new/

https://reviews.llvm.org/D119198