[libcxx-commits] [PATCH] D119208: [libc++] WIP: use no_unique_address for base in join_view

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__ranges/join_view.h:71
     [[no_unique_address]] _Cache __cache_;
-    _View __base_ = _View(); // TODO: [[no_unique_address]] makes clang crash! File a bug :)
 
----------------
Was a bug ever filed? If not, please do; if so, please give a link in the commit message.

FWIW, in the absence of any other information, I'd trust the old code comment that says "don't do this" over the CI results. ;)  But I'm very curious to understand what the old code comment was talking about, because how on earth could the attribute be OK on `__cache_` but ICE the compiler on `__base_`??


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119208/new/

https://reviews.llvm.org/D119208