[libcxx-commits] [PATCH] D119189: [libc++] Add papers from February 2022 plenary meeting

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 8 07:51:06 PST 2022


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Thanks for updating the feature macros at the same time as the csv! We should get in that habit. :)
LGTM%comment, but I did not exhaustively double-check anything.



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:238
+  }, {
+    "name": "__cpp_lib_constexpr_math",
+    "values": { "c++2b": 202202 },
----------------
This should say `__cpp_lib_constexpr_cmath`, according to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p0533r9.pdf . (This is the only one I spot-checked, because it smelled wrong — the name of the header is `<cmath>`, not `<math>`. I did not check the others.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119189/new/

https://reviews.llvm.org/D119189



More information about the libcxx-commits mailing list