[libcxx-commits] [PATCH] D119208: [libc++] WIP: use no_unique_address for base in join_view

[Joe Loser via Phabricator via libcxx-commits]

jloser created this revision.
jloser requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Let's see what CI says. I think this will work fine in clang13 onward which is
all we care about soon.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119208

Files:
  libcxx/include/__ranges/join_view.h


Index: libcxx/include/__ranges/join_view.h
===================================================================
--- libcxx/include/__ranges/join_view.h
+++ libcxx/include/__ranges/join_view.h
@@ -68,7 +68,7 @@
     static constexpr bool _UseCache = !is_reference_v<_InnerRange>;
     using _Cache = _If<_UseCache, __non_propagating_cache<remove_cvref_t<_InnerRange>>, __empty_cache>;
     [[no_unique_address]] _Cache __cache_;
-    _View __base_ = _View(); // TODO: [[no_unique_address]] makes clang crash! File a bug :)
+    [[no_unique_address]] _View __base_ = _View();
 
   public:
     _LIBCPP_HIDE_FROM_ABI


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119208.406674.patch
Type: text/x-patch
Size: 613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220208/acfb3d52/attachment.bin>