[libcxx-commits] [PATCH] D119159: [libc++] Make shared_ptr move unique_ptr's deleter

Asher Mancinelli via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 7 17:38:08 PST 2022


ashermancinelli marked an inline comment as done.
ashermancinelli added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/unique_ptr.pass.cpp:258
+      assert(&i == s.get());
+    }
+
----------------
I'm not sure this test is helpful, though it does roughly demonstrate  `s(std::move(u));` is +/= equivilant to `s(u.release(), std::move(u.get_deleter()));` imo. Happy to remove if reviewers find it unhelpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119159/new/

https://reviews.llvm.org/D119159



More information about the libcxx-commits mailing list