[libcxx-commits] [PATCH] D119198: [libc++] Remove default_searcher from experimental/functional

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 7 15:38:43 PST 2022


jloser created this revision.
jloser added reviewers: ldionne, Quuxplusone, Mordante, var-const, philnik.
jloser requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

`std::default_searcher` has been implemented for a while now
(introduced in d835e59211883) - far more than two llvm releases. So, remove it
from `experimental/functional`. Keep `make_default_searcher` but make it
C++17-or-later only instead of C++14-or-later since `std::default_searcher` is
only defined in C++17 or later.

There already exists tests for `std::default_searcher` in
`libcxx/test/std/utilities/function.objects/func.search/func.search.default`, so
there is no loss in test coverage.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119198

Files:
  libcxx/include/experimental/functional
  libcxx/test/std/experimental/func/func.searchers/func.searchers.default/default.pass.cpp
  libcxx/test/std/experimental/func/func.searchers/func.searchers.default/default.pred.pass.cpp
  libcxx/test/std/experimental/func/func.searchers/func.searchers.default/func.searchers.default.creation/make_default_searcher.pass.cpp
  libcxx/test/std/experimental/func/func.searchers/func.searchers.default/func.searchers.default.creation/make_default_searcher.pred.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119198.406634.patch
Type: text/x-patch
Size: 13205 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220207/92329ee7/attachment-0001.bin>


More information about the libcxx-commits mailing list