[libcxx-commits] [PATCH] D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.

Mon Feb 7 13:29:54 PST 2022

ldionne marked 3 inline comments as done.
ldionne added inline comments.

================
Comment at: libcxx/test/std/atomics/stdatomic.h.syn/types.pass.cpp:21
+// #define ATOMIC_CHAR_LOCK_FREE see below
+// TODO: No ATOMIC_CHAR8_T_LOCK_FREE, but atomic_char8_t is present in synopis?? NB that atomic_char8_t is not in C11. See http://eel.is/c++draft/stdatomic.h.syn.
+// #define ATOMIC_CHAR16_T_LOCK_FREE see below
----------------
ldionne wrote:
> curdeius wrote:
> > Anyone has an idea about this? Is this an omission in the standard (given that it includes `atomic_char8_t`) or it should match C11 and so omit both `ATOMIC_CHAR8_T_LOCK_FREE` and `atomic_char8_t`?
> GCC does define `ATOMIC_CHAR8_T_LOCK_FREE`. I think this is likely an oversight in the spec.
> 
> @timshen Would you agree?
> 
> @curdeius I think we should add both `ATOMIC_CHAR8_T_LOCK_FREE` and `atomic_char8_t`.
I'm actually going to implement this naively for now and not check for `ATOMIC_CHAR8_T_LOCK_FREE`. This will end up being the target of a LWG issue anyway, so we can add the check then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97044/new/

https://reviews.llvm.org/D97044