[libcxx-commits] [PATCH] D100504: [libc++abi][AIX] add personality and helper functions for the state table EH

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 7 13:11:32 PST 2022


xingxue updated this revision to Diff 406538.
xingxue marked 32 inline comments as done.
xingxue retitled this revision from "[libc++abi][AIX] initial patch for EH on AIX" to "[libc++abi][AIX] add personality and helper functions for the state table EH".
xingxue edited the summary of this revision.
xingxue edited reviewers, added: compnerd; removed: jasonliu.
xingxue added a comment.

Addressed comments.

- Used `union`s where the same memory is used for different purposes to make overlapping use of the memory more clear.
- Renamed variables to be more descriptive.
- Added a high level description of the state table based EH.
- Added comments in various locations.
- Fixed a problem where the frame pointer is needed to calculate the address.
- Fixed the address calculation of virtual base object for calling destructor or deletor to be based on the IBM object model used by the proprietary `xlC` compiler because these paths are only used for `xlC` generated code.
- Commoned up some code to reduce redundancy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100504/new/

https://reviews.llvm.org/D100504

Files:
  libcxxabi/src/cxa_personality.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100504.406538.patch
Type: text/x-patch
Size: 33431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220207/b2bde293/attachment-0001.bin>


More information about the libcxx-commits mailing list