[libcxx-commits] [PATCH] D119173: [libc++] Remove _LIBCPP_ABI_UNSTABLE

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/gdb/libcxx/printers.py:10
 
-These should work for objects compiled when _LIBCPP_ABI_UNSTABLE is defined
-and when it is undefined.
+These should work for objects compiled with the stable and unstable ABI.
 """
----------------
Quuxplusone wrote:
> `These should work for objects compiled with either the stable ABI or the unstable ABI.` (Or both? Is "both" a physical possibility?)
Good suggestion. I think the intent of the comment is to say that the pretty printers are ABI independent. I think it would be physically possible to compile a single object file with two libc++s on different ABI versions, but IDK how the pretty printers would handle it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119173/new/

https://reviews.llvm.org/D119173