[libcxx-commits] [PATCH] D119059: [libc++][CI] Put runs into groups

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This is really neat, I didn't know BuildKite supported that feature! Some comments but otherwise LGTM.



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:327-338
   - label: "-fno-exceptions"
     command: "libcxx/utils/ci/run-buildbot generic-noexceptions"
     artifact_paths:
       - "**/test-results.xml"
     agents:
       queue: "libcxx-builders"
       os: "linux"
----------------
I would rename this one to "No exceptions" and move it to "Parts disabled".


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:394-405
   - label: "Single-threaded"
     command: "libcxx/utils/ci/run-buildbot generic-singlethreaded"
     artifact_paths:
       - "**/test-results.xml"
     agents:
       queue: "libcxx-builders"
       os: "linux"
----------------
I would actually rename this one to "No threads" and move it to the "Parts disabled" group.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119059/new/

https://reviews.llvm.org/D119059