[libcxx-commits] [PATCH] D119097: [libc++] Mark some members private in experimental/functional

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 6 16:51:44 PST 2022


jloser created this revision.
jloser added reviewers: ldionne, Mordante, Quuxplusone, philnik, var-const.
jloser requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Some members are public but should be private. Nothing requires they are public
right now, so make them private.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119097

Files:
  libcxx/include/experimental/functional


Index: libcxx/include/experimental/functional
===================================================================
--- libcxx/include/experimental/functional
+++ libcxx/include/experimental/functional
@@ -144,7 +144,6 @@
 //  General case for BM data searching; use a map
 template<class _Key, typename _Value, class _Hash, class _BinaryPredicate>
 class _BMSkipTable<_Key, _Value, _Hash, _BinaryPredicate, false> {
-public: // TODO private:
     typedef _Value value_type;
     typedef _Key   key_type;
 
@@ -253,7 +252,7 @@
         return this->__search(__f, __l);
     }
 
-public: // TODO private:
+private:
     _RandomAccessIterator1               __first_;
     _RandomAccessIterator1               __last_;
     _BinaryPredicate                     __pred_;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119097.406300.patch
Type: text/x-patch
Size: 766 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220207/504d6647/attachment.bin>


More information about the libcxx-commits mailing list