[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:12-13
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-W#warnings"
+
----------------
What does this pragma do, and what goes wrong if you omit it?


================
Comment at: libcxx/test/libcxx/lint/lint_headers.sh.py:1
-# RUN: %{python} %s
-
----------------
Please don't delete `lint_headers.sh.py`. It does things that clang-tidy can't, such as check for the existence of `#  pragma GCC system_header` and (soon) check for the existence of `#include <__config>`.
We can discuss whether the 12 lines concerned with include-sorting are now permanently obsoleted (because we trust clang-tidy to check include-sorting forever more), but FYI //personally// I don't trust clang-tidy and //personally// I don't think 12 lines is too much to pay for peace of mind. Again, if clang-tidy ever disagreed with this script, clang-tidy would be wrong by definition.


================
Comment at: libcxx/utils/libcxx/test/features.py:107-108
+
+  Feature(name='has-clang-tidy',
+          when=lambda cfg: runScriptExitCode(cfg, ['clang-tidy --version']) == 0),
 ]
----------------
Consider indenting to match the other lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174