[libcxx-commits] [PATCH] D118950: [libc++] Remove `_LIBCPP_DEBUG` and replace with `_LIBCPP_DEBUG_LEVEL`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This looks correct to me, but thanks for waiting. The debug mode is sometimes tricky, but in this case this really looks like an oversight. Basically, `_LIBCPP_DEBUG` is the user-facing option, and the library should use `_LIBCPP_DEBUG_LEVEL` internally.

However, the commit summary says "Remove `_LIBCPP_DEBUG` and replace with `_LIBCPP_DEBUG_LEVEL`", which is misleading. I thought you were removing `_LIBCPP_DEBUG` entirely at first. I think this would be better: "Remove usage of _LIBCPP_DEBUG in __comp_ref_type" or something along those lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118950/new/

https://reviews.llvm.org/D118950