[libcxx-commits] [PATCH] D118926: [libc++] Adds TEST_IF_INT128.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I will admit I'm not convinced that we're saving much here, in particular I'm a bit concerned with the fact that these `IF(...)` macros are less usual (if more terse) than the basic `#if defined(...)`, and so one might have to look it up.

All in all I'm not strongly against, and I especially don't want to block you if it makes a big difference in upcoming `std::format` tests, but if the gain in `std::format` is not compelling, I'd rather not do this. If it's a compelling gain for `std::format`, I can definitely live with this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118926/new/

https://reviews.llvm.org/D118926