[libcxx-commits] [PATCH] D118901: [libc++] Disable incomplete features for the LLVM 14 release

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 4 11:38:00 PST 2022


ldionne updated this revision to Diff 406060.
ldionne added a comment.

Try to fix the CI -- I think this should be good.

This is kind of nasty, I'll have to cherry-pick some of these changes back onto main.
There's a couple of problems:

1. The benchmarks didn't work when incomplete features were disabled -- that's trivial to fix
2. The modular build is not compatible with various knobs we have in the __config_site. For example, you can't use the modular build with LIBCXX_ENABLE_LOCALIZATION=OFF. A lot of stuff is going to break. In this patch, I am fixing just enough for the modular build to work when incomplete features are disabled, but we should really investigate the situation so that the modular build works with all configuration knobs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118901/new/

https://reviews.llvm.org/D118901

Files:
  libcxx/CMakeLists.txt
  libcxx/benchmarks/CMakeLists.txt
  libcxx/docs/ReleaseNotes.rst
  libcxx/include/module.modulemap
  libcxx/lib/abi/arm64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxxabi/test/libcxxabi/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118901.406060.patch
Type: text/x-patch
Size: 12738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220204/3559e564/attachment-0001.bin>


More information about the libcxx-commits mailing list