[libcxx-commits] [PATCH] D118914: [libc++] Move fpos into its own header

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__ios/fpos.h:17
+#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
+#  pragma GCC system_header
+#endif
----------------
Quuxplusone wrote:
> D118800 is related. Please use the prevailing style until/unless we agree to do something different:
> ```
> $ git grep '#pragma GCC system_header' ../libcxx/include/ | wc -l
>      484
> $ git grep '# pragma GCC system_header' ../libcxx/include/ | wc -l
>        1
> $ git grep '#  pragma GCC system_header' ../libcxx/include/ | wc -l
>       16
> $ git grep '#   pragma GCC system_header' ../libcxx/include/ | wc -l
>        2
> $ git grep '#    pragma GCC system_header' ../libcxx/include/ | wc -l
>        0
> ```
I'll go with 2 spaces here, since that seems to be what you do in D118800.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118914/new/

https://reviews.llvm.org/D118914