[libcxx-commits] [PATCH] D118940: [libc++] Fix std::__debug_less in c++17.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a subscriber: ldionne.
Quuxplusone added a comment.

The patch looks good to me now... but we //do// have a buildkite runner that runs in Debug mode, and it didn't catch the thing you originally mentioned.
Can someone explain why `libcxx/test/std/algorithms/alg.sorting/alg.min.max/min_init_list_comp.pass.cpp` does not detect the problem?  I paste it into Godbolt and it detects the problem: https://godbolt.org/z/eKvcvbb7d yet the "Debug mode" buildkite job isn't failing.

...Ooh. It's because the "Debug mode" buildkite job uses only C++20 or C++2b, isn't it? The combinatorial explosion of config options strikes again. :(  @ldionne @philnik any thoughts on how to improve our CI coverage here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118940/new/

https://reviews.llvm.org/D118940