[libcxx-commits] [PATCH] D118914: [libc++] Move fpos into its own header

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__ios/fpos.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Since you're `_LIBCPP_HIDE_FROM_ABI`'ing this code already, do you also want to 2-space-indent it?


================
Comment at: libcxx/include/__ios/fpos.h:17
+#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
+#  pragma GCC system_header
+#endif
----------------
D118800 is related. Please use the prevailing style until/unless we agree to do something different:
```
$ git grep '#pragma GCC system_header' ../libcxx/include/ | wc -l
     484
$ git grep '# pragma GCC system_header' ../libcxx/include/ | wc -l
       1
$ git grep '#  pragma GCC system_header' ../libcxx/include/ | wc -l
      16
$ git grep '#   pragma GCC system_header' ../libcxx/include/ | wc -l
       2
$ git grep '#    pragma GCC system_header' ../libcxx/include/ | wc -l
       0
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118914/new/

https://reviews.llvm.org/D118914