[libcxx-commits] [PATCH] D118901: [libc++] Disable incomplete features for the LLVM 14 release

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/CMakeLists.txt:136
     ABI stability nor the quality of completed library features. Vendors
-    shipping the library may want to disable this option." ON)
+    shipping the library may want to disable this option." OFF)
 set(LIBCXX_TEST_CONFIG "legacy.cfg.in" CACHE STRING
----------------
No objection to this change. However I think the release notes need to be updated. The first bullet regarding `<format>` contains the wording.
```
  Vendors can still disable this header by turning the CMake option
  LIBCXX_ENABLE_INCOMPLETE_FEATURES off.
```
The current wording implies ON is the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118901/new/

https://reviews.llvm.org/D118901