[libcxx-commits] [PATCH] D118914: [libc++] Move fpos into its own header

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 3 09:12:50 PST 2022


Mordante added a comment.

The test `test/std/input.output/iostreams.base/fpos/fpos.operations/fpos.pass.cpp` also needs to be updated

- Update the includes
- Update the synopsis



================
Comment at: libcxx/include/__ios/fpos.h:29
+public:
+    _LIBCPP_INLINE_VISIBILITY fpos(streamoff __off = streamoff()) : __st_(), __off_(__off) {}
+
----------------
Would be nice to use `_LIBCPP_HIDE_FROM_ABI` here.


================
Comment at: libcxx/include/__ios/fpos.h:56
+    {return streamoff(__x) != streamoff(__y);}
+
+
----------------
Please remove one blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118914/new/

https://reviews.llvm.org/D118914



More information about the libcxx-commits mailing list