[libcxx-commits] [PATCH] D118874: [libc++][nfc] Use TEST_SAFE_STATIC.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/default.pass.cpp:33
 
 #if defined(_LIBCPP_VERSION) && TEST_STD_VER >= 11
+TEST_SAFE_STATIC std::unique_ptr<int> global_static_unique_ptr_single;
----------------
ldionne wrote:
> It looks like it might be possible to remove the `if defined(_LIBCPP_VERSION)` now?
> 
> Also, I don't quite understand the purpose of the variable itself, but I guess that's an orthogonal question.
I haven't looked at what this is exactly used for, I just try to remove the libc++ specific dependencies from the tests. 
The attribute enabled is https://clang.llvm.org/docs/AttributeReference.html#require-constant-initialization-constinit-c-20


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118874/new/

https://reviews.llvm.org/D118874