[libcxx-commits] [PATCH] D118902: [libc++] Fix chrono::duration constructor constraint

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 3 06:59:55 PST 2022


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for your patch!

Can you please add a test for this? The correct file seems like it should be `libcxx/test/std/utilities/time/time.duration/time.duration.cons/rep.pass.cpp`.

Also, if you need someone to commit this for you, please provide `Author Name <email at domain>` for commit attribution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118902/new/

https://reviews.llvm.org/D118902



More information about the libcxx-commits mailing list