[libcxx-commits] [PATCH] D118874: [libc++][nfc] Use TEST_SAFE_STATIC.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 3 05:50:02 PST 2022
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/default.pass.cpp:33
#if defined(_LIBCPP_VERSION) && TEST_STD_VER >= 11
+TEST_SAFE_STATIC std::unique_ptr<int> global_static_unique_ptr_single;
----------------
It looks like it might be possible to remove the `if defined(_LIBCPP_VERSION)` now?
Also, I don't quite understand the purpose of the variable itself, but I guess that's an orthogonal question.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118874/new/
https://reviews.llvm.org/D118874
More information about the libcxx-commits
mailing list