[libcxx-commits] [PATCH] D118634: [libc++][ranges] Add ranges::in_out_out_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM % comments!



================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp:14
+// template <class I, class O1, class O2>
+// struct in_out_out_result;
 
----------------
I believe you changed the copy-paste error in the wrong (original) file! Please undo it here, and do it there.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp:78
+  {
+    std::ranges::in_out_out_result<int, double, float> res{10L, 0., 1.f};
+    assert(res.in == 10);
----------------
Mordante wrote:
> Why do you use `10L` when you want an `int`?
This, also, was fixed in the original file. (Please keep it fixed there, but also fix it here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118634/new/

https://reviews.llvm.org/D118634