[libcxx-commits] [PATCH] D118838: [libc++] Add UNSUPPORTED for clang-15

Haowei Wu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 14:46:23 PST 2022


haowei added a comment.

In D118838#3292088 <https://reviews.llvm.org/D118838#3292088>, @ldionne wrote:

> Oh, thanks, I was literally going to land the same change! I assume you noticed the Bootstrapping build was failing?
>
> @haowei Just for the sake of the process, in the future, please try to follow the libc++ review guidelines <https://libcxx.llvm.org/Contributing.html#the-review-process> and wait for the libc++ review group to be green before committing. You can always ping us on Discord if you're missing some approvals on a simple (and time critical) change like this, and we'll be happy to take a look quickly. Thanks for the patch!

Oh, sorry I will follow the guideline next time. I thought the review process were the same.

I saw breakages on Fuchsia's clang linux builders due this test after the version was bumped to 15. And I found it out this test was broken since clang-13. So I just added clang-15 since the underlying bug was not yet fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118838/new/

https://reviews.llvm.org/D118838



More information about the libcxx-commits mailing list