[libcxx-commits] [PATCH] D118686: [libc++][ranges][NFC] Test the specializations of `tuple_{size, element}` for ranges.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 14:36:26 PST 2022


ldionne accepted this revision.
ldionne added a comment.

LGTM.

I understand @Quuxplusone 's point about this being somewhat redundant, however adding these tests is consistent with what we're doing for the `<array>` and `<utility>` tests in the same directory. If we don't find that this adds enough value, we should be removing the tests for `<array>` and `<utility>` instead.

However, from my point of view, these three tests do add some value (especially since we like to move stuff around in the headers, and I can definitely imagine we'd break users relying on this guarantee).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118686/new/

https://reviews.llvm.org/D118686



More information about the libcxx-commits mailing list