[libcxx-commits] [PATCH] D118686: [libc++][ranges][NFC] Test the specializations of `tuple_{size, element}` for ranges.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 13:01:24 PST 2022


var-const added a comment.

In D118686#3291426 <https://reviews.llvm.org/D118686#3291426>, @ldionne wrote:

> In D118686#3289137 <https://reviews.llvm.org/D118686#3289137>, @var-const wrote:
>
>> 
>
> Yes, that sounds like the correct thing to do.

Done.

> I'm neutral on this. I think we should aim for the simplest test that gives us confidence that we're doing the right thing. We should avoid getting into diminishing returns IMO.

Ok, in that case, I'll just test the `subrange` specializations, similar to the existing tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118686/new/

https://reviews.llvm.org/D118686



More information about the libcxx-commits mailing list