[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 10:16:31 PST 2022


Mordante added a comment.

I'm not to familiar with this part of the Standard so didn't do an in-depth review. But I didn't see any oddities.



================
Comment at: libcxx/include/__memory/shared_ptr.h:982
+    _LIBCPP_HIDE_FROM_ABI
+    _Tp* __get_elem_begin() noexcept { return reinterpret_cast<_Tp*>(&__data_); }
+
----------------
Let's guard against ADL-hijacking. (The required header is already included.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62641/new/

https://reviews.llvm.org/D62641



More information about the libcxx-commits mailing list