[libcxx-commits] [PATCH] D118733: [libc++] Remove the std::string base class

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

This change breaks ABI stability in the CI, so it needs more work.



================
Comment at: libcxx/include/string:686
-#ifndef _LIBCPP_ABI_NO_BASIC_STRING_BASE_CLASS
-    : private __basic_string_common<true> // This base class is historical, but it needs to remain for ABI compatibility
-#endif
----------------
The comment contradicts the commit message. But the base indeed seems to be empty.


================
Comment at: libcxx/src/string.cpp:24
 
 #ifndef _LIBCPP_ABI_NO_BASIC_STRING_BASE_CLASS
 
----------------
Maybe add a comment here that the struct isn't declared in any header anymore and is only provided here to export the symbols for ABI stability. (It's kind of obvious when you think about it, but can't hurt to explain it for future readers.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118733/new/

https://reviews.llvm.org/D118733