[libcxx-commits] [PATCH] D118736: [libc++] Guard std::ranges under _LIBCPP_HAS_NO_INCOMPLETE_RANGES.

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 09:14:02 PST 2022


jloser added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:487
 
-#ifdef TEST_SUPPORTS_RANGES
+#if TEST_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+
----------------
Do we want to keep `TEST_STD_VER > 17` check since we have `!defined(_LIBCPP_HAS_NO_CONCEPTS) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118736/new/

https://reviews.llvm.org/D118736



More information about the libcxx-commits mailing list