[libcxx-commits] [PATCH] D118740: [libc++] Add CI without experimental features and don't exclude span from the tests

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:10
 // UNSUPPORTED: libcpp-no-concepts
-// UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
----------------
ldionne wrote:
> jloser wrote:
> > If we remove this, do we need to replace it with `XFAIL: apple-clang-12.0.0`?  This goes for other span tests too, but most (all but this one?) have the `XFAIL` already.
> I don't think we need the XFAIL here because we are not using concepts in this test AFAICS. CI will let us know if we need to add it.
Looks like you're right according to CI. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118740/new/

https://reviews.llvm.org/D118740