[libcxx-commits] [PATCH] D118736: [libc++] Guard std::ranges under _LIBCPP_HAS_NO_INCOMPLETE_RANGES.

Tue Feb 1 14:32:43 PST 2022

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Apart from my comments, this looks reasonable and desirable in time for LLVM 14.

================
Comment at: libcxx/include/__algorithm/in_in_out_result.h:19

-#ifndef _LIBCPP_HAS_NO_CONCEPTS
+#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)

----------------
Please only add `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` in this patch. If we decide to change the meaning of `_LIBCPP_HAS_NO_CONCEPTS` to not include `_LIBCPP_STD_VER > 17`, we should do it in a separate patch.

================
Comment at: libcxx/test/libcxx/ranges/has-no-incomplete-ranges.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I don't think this test adds that much value -- instead, we should just add a CI configuration that tests without incomplete features, and also make sure not to needlessly mark tests as `UNSUPPORTED` (like we did for the span ones).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118736/new/

https://reviews.llvm.org/D118736