[libcxx-commits] [PATCH] D118719: [libc++] Remove unneeded qualifier.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 1 13:18:40 PST 2022


Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Ship it!



================
Comment at: libcxx/include/__format/format_arg.h:148
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_FORMAT friend decltype(auto)
-  _VSTD::visit_format_arg(_Visitor&& __vis, basic_format_arg<_Ctx> __arg);
+  visit_format_arg(_Visitor&& __vis, basic_format_arg<_Ctx> __arg);
 
----------------
FWIW, the order of `friend` vs `_LIBCPP_HIDE_FROM_ABI` is different here compared to line 134 of `format_context.h`.



================
Comment at: libcxx/include/__format/format_context.h:148
   friend _LIBCPP_HIDE_FROM_ABI basic_format_context<__OutIt, __CharT>
-      _VSTD::__format_context_create(
-          __OutIt, basic_format_args<basic_format_context<__OutIt, __CharT>>);
+      __format_context_create(__OutIt, basic_format_args<basic_format_context<__OutIt, __CharT>>);
 
----------------
This line is unnecessarily indented; compare to line 135 above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118719/new/

https://reviews.llvm.org/D118719



More information about the libcxx-commits mailing list