[libcxx-commits] [PATCH] D117811: [libc++] Remove _VSTD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__format/format_arg.h:141
       _LIBCPP_AVAILABILITY_FORMAT friend __format_arg_store<_Ctx, _Args...>
-      _VSTD::make_format_args(const _Args&...);
+      std::_LIBCPP_ABI_NAMESPACE::make_format_args(const _Args&...);
 
----------------
Mordante wrote:
> Why is this required? Is this the `Add gcc workarounds`? This deviates from the previous assertion that there was no difference between using `std::` and `std::__1::`. The requirement to sometimes use `std::_LIBCPP_ABI_NAMESPACE` instead of `std::` feels error prone to me.
> 
> 
Yes, these are the GCC workarounds. I think this is a GCC bug, but nobody has confirmed it yet, so I didn't open an issue. It seems GCC doesn't handle friends properly with inline namespaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117811/new/

https://reviews.llvm.org/D117811