[libcxx-commits] [PATCH] D118686: [libc++][ranges] Specialize `tuple_{size, element}` for ranges.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 1 08:27:56 PST 2022


Quuxplusone requested changes to this revision.
Quuxplusone added a comment.
This revision now requires changes to proceed.

I believe this is redundant with D108054 <https://reviews.llvm.org/D108054>, which was committed quite a while ago now.
Anyway, specializations and customizations (of `swap`, `hash`, `get`, `tuple_size`, `enable_borrowed_range`, `is_error_code_enum`,...) belong next to the class they appertain to, not in a separate header. So if there's actually something to do here, please move the code into the `subrange.h` header (at which point it becomes at best a diff against what's there now).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118686/new/

https://reviews.llvm.org/D118686



More information about the libcxx-commits mailing list