[libcxx-commits] [PATCH] D118432: [libc++][ranges] Implement `indirectly_copyable{, _storable}`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked an inline comment as not done.
var-const added a comment.

In D118432#3281773 <https://reviews.llvm.org/D118432#3281773>, @Quuxplusone wrote:

> In D118432#3281339 <https://reviews.llvm.org/D118432#3281339>, @var-const wrote:
>
>> Note: I've also updated all the `iterator_concept_conformance` tests (under the assumption that for iterators, `indirectly_copyable{,_storable}` always behaves the same as `indirectly_movable{,_storable}`.
>
> I have a patch locally (but apparently never got around to submitting it for review) that simply //removes// all of the "detail" concepts from every `iterator_concept_conformance.compile.pass.cpp`, leaving only the iterator concepts like `forward_iterator` and `bidirectional_iterator` (and only the relevant ones of //those//, even). I don't object to your expanding those tests, but I certainly wasn't going to ask you to do it.

I see, thanks for the heads-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118432/new/

https://reviews.llvm.org/D118432