[libcxx-commits] [PATCH] D138196: [libc++] Use aligned_alloc instead of posix_memalign for C++17

Gulfem Savrun Yeniceri via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 29 11:50:19 PST 2022


gulfem added a comment.

In D138196#4019614 <https://reviews.llvm.org/D138196#4019614>, @thakis wrote:

> Re ChromeOS above: turns out we build some bits for Android in ChromeOS builds, so that's just the android thing again.
>
> In D138196#4019563 <https://reviews.llvm.org/D138196#4019563>, @gulfem wrote:
>
>> This seems to break our toolchain builders for Fuchsia.
>> https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.prod.core.x64-release-subbuild/b8794045085201621697/overview
>
> Do you know what the aligned_alloc story in your C library is? Which C runtime library does fuchsia use?
>
> (Chromium's Fuchsia builders are fine with this change fwiw.)

It seems like we fixed the issue on the Fuchsia side (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/782063), and I missed that fix because of the holidays.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138196/new/

https://reviews.llvm.org/D138196



More information about the libcxx-commits mailing list