[libcxx-commits] [PATCH] D140632: [NFC][libc++] Removes concepts tests.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D140632#4016552 <https://reviews.llvm.org/D140632#4016552>, @h-vetinari wrote:

>> Clang trunk doesn't claim support: https://godbolt.org/z/hes3nah8s. I'm actually quite surprised this doesn't break the CI. I remember having problems with at least Clang 15 when trying to use conditionally trivial special member functions.
>
> See https://reviews.llvm.org/D128619; it's implemented, but there are still a large number of open concept issues so the feature macro hasn't been set.

That might be true, but this part seems to work. So I really would like to land this.
We normally don't use feature-test macros in our test, instead we define a helper macro which we use in the tests.
Since it works it makes little sense to add a helper macro to do the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140632/new/

https://reviews.llvm.org/D140632