[libcxx-commits] [PATCH] D137022: [libc++][chrono] Add calendar type formatters.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 4 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/time/time.cal/time.cal.md/time.cal.md.nonmembers/ostream.pass.cpp:77
+  assert(stream_c_locale<CharT>(std::chrono::month_day{std::chrono::month{2}, 29d}) == SV("Feb/29"));
+  // TODO FMT there is no validation in this ostream operator.
+  assert(stream_c_locale<CharT>(std::chrono::month_day{std::chrono::month{6}, 31d}) == SV("Jun/31"));
----------------
ldionne wrote:
> Is this a leftover?
No it's something that looks like a bug in the Standard. I have improved the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137022/new/

https://reviews.llvm.org/D137022