[libcxx-commits] [PATCH] D140480: [libc++] Granularize <type_traits> includes in <compare>

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 21 08:35:57 PST 2022


Mordante added a comment.

LGTM, thanks for the cleanup! It seems the transitive includes only add new indirect paths in older language versions, no objection from me.



================
Comment at: libcxx/include/__memory/assume_aligned.h:17
 #include <cstdint>
-#include <type_traits> // for is_constant_evaluated()
 
----------------
Nice I really dislike these comments, this change makes it obsolete :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140480/new/

https://reviews.llvm.org/D140480



More information about the libcxx-commits mailing list