[libcxx-commits] [libcxx] 6198f3a - [libc++] Also install libclang in the Docker image

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 21 06:39:32 PST 2022


Author: Nikolas Klauser
Date: 2022-12-21T15:39:26+01:00
New Revision: 6198f3abf56f10bee6b3ba771c2de4a922429d4d

URL: https://github.com/llvm/llvm-project/commit/6198f3abf56f10bee6b3ba771c2de4a922429d4d
DIFF: https://github.com/llvm/llvm-project/commit/6198f3abf56f10bee6b3ba771c2de4a922429d4d.diff

LOG: [libc++] Also install libclang in the Docker image

This is now everything that is required for clang-tidy checks.

Reviewed By: #libc, ldionne

Spies: libcxx-commits, arichardson

Differential Revision: https://reviews.llvm.org/D140424

Added: 
    

Modified: 
    libcxx/utils/ci/Dockerfile

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 2db95fc13f280..67c94bd88f09d 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -84,11 +84,12 @@ RUN ln -s /usr/bin/git-clang-format-14 /usr/bin/git-clang-format && [ -e $(readl
 RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION clang-tidy-14
 RUN ln -s /usr/bin/clang-tidy-14 /usr/bin/clang-tidy && [ -e $(readlink /usr/bin/clang-tidy) ]
 
-# Install llvm-dev to compile custom clang-tidy checks
-RUN apt-get update && apt-get install llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev
+# Install llvm-dev and libclang-dev to compile custom clang-tidy checks
+RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 1))-dev     llvm-$(($LLVM_HEAD_VERSION - 2))-dev \
+                                     libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$(($LLVM_HEAD_VERSION - 2))-dev
 
 # TODO LLVM16 Don't install llvm-16-dev explicitly
-RUN apt-get update && apt-get install llvm-16-dev
+RUN apt-get update && apt-get install -y llvm-16-dev libclang-16-dev
 
 # Install clang-tools
 RUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 1)) clang-tools-$LLVM_HEAD_VERSION


        


More information about the libcxx-commits mailing list