[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

Tue Dec 20 17:13:28 PST 2022

ldionne added a comment.

Thanks for picking this up, it's great to see progress being made.

================
Comment at: libcxx/include/__config:134
 // are deprecated.
-#    if defined(__FreeBSD__)
+#    if defined(__FreeBSD__) && !defined(_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR)
 #      define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
----------------
emaste wrote:
> philnik wrote:
> > emaste wrote:
> > > emaste wrote:
> > > > should this part be committed independently?
> > > Can we commit this separately first?
> > I'm sure we can. Just create a patch; though I don't understand why this change is even needed. 
> Related to D126462 I suppose, @ldionne?
I don't understand the purpose of this change either TBH. If FreeBSD doesn't support the old ABI for pair, I think it should just be removed, so this macro can go away entirely?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084