[libcxx-commits] [PATCH] D140343: [libc++] List supported libcs

Tue Dec 20 16:53:40 PST 2022

ldionne added inline comments.

================
Comment at: libcxx/docs/index.rst:119
+=============== ========================= ====================== ============================
+macOS 10.9+     i386, x86_64, arm64       ???-???                Building the shared library itself requires targetting macOS 10.11+
+FreeBSD 10+     i386, x86_64, arm         ???-???
----------------
For macOS, there's only the system libc, so it doesn't really make much sense. In other words, by saying macOS 10.9 +, we are basically specifying what libcs are supported.

================
Comment at: libcxx/docs/index.rst:120
+macOS 10.9+     i386, x86_64, arm64       ???-???                Building the shared library itself requires targetting macOS 10.11+
+FreeBSD 10+     i386, x86_64, arm         ???-???
+Linux           i386, x86_64, arm, arm64  glibc-2.24+
----------------
philnik wrote:
> emaste wrote:
> > FreeBSD 10 and 11 are out of support now, so we likely won't be testing against the libc they came with. I think it would be fine to make this FreeBSD 12+. In addition, FreeBSD uses/supports libc++ across all of our supported architectures -- 32- and 64-bit x86, arm, powerpc, as well as 64-bit riscv.
> > 
> > FreeBSD has an integrated base system that includes the kernel, libc, userland tools etc., and generally doesn't have a concept of alternate libcs -- e.g. FreeBSD 12.3 has FreeBSD 12.3 libc. I'm not sure what we'd put in this table.
> > 
> > Perhaps we should just put the required glibc version in Notes for the Linux row?
> > 
> > 
> > FreeBSD 10 and 11 are out of support now, so we likely won't be testing against the libc they came with. I think it would be fine to make this FreeBSD 12+. In addition, FreeBSD uses/supports libc++ across all of our supported architectures -- 32- and 64-bit x86, arm, powerpc, as well as 64-bit riscv.
> I'll update the version. For the architectures, please provide BuildKite bots, then we can update the list. I'm not 100% sure what the policy for architectures is, but we currently don't have any RISCV bots, so we definitely need one for that. We probably also require one per platform/architecture combination.
> > FreeBSD has an integrated base system that includes the kernel, libc, userland tools etc., and generally doesn't have a concept of alternate libcs -- e.g. FreeBSD 12.3 has FreeBSD 12.3 libc. I'm not sure what we'd put in this table.
> We can just put `N/A` in the table.
> > Perhaps we should just put the required glibc version in Notes for the Linux row?
> Let's see what other people have to say here. If this indeed only affects Linux we can do that, but I expect that it'll also affect at least Windows due to MinGW. I think MSVCRT also isn't bound to a windows version. @mstorsjo probably has more insight there.
> 
> Perhaps we should just put the required glibc version in Notes for the Linux row?

This is exactly what I was going to suggest -- IMO that makes the most sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140343/new/

https://reviews.llvm.org/D140343